Messages in this thread |  | | Date | Sat, 6 Oct 2001 01:07:25 +0200 | From | Vojtech Pavlik <> | Subject | Re: New Input PS/2 driver |
| |
On Fri, Oct 05, 2001 at 04:02:08PM -0700, James Simmons wrote: > > > > Not implemented yet. > > > > Quite the opposite: #undef was forgotten in the .h file after the .c > > file converted to a runtime option instead of a compiletime one. I > > removed it in the CVS now. > > Okay. Another thing is how to deal with IRQ's and the port regions. This > can vary from platform to platform. We could have this as a command line > option as well. In fact we might since it can be built as a module. Alot > of platforms added things to the command line inside the kernel code. > Or we can do lots of #ifdef in i8042.h or using the asm/keyboard method > like now. Personally I don't like this method since even on mips the i8042 > port range varies on different machines. So we still end up with a bunch > of messy #ifdef.
I'd prefer a bunch of #ifdefs in i8042.h with defaults and a command line option to change that if needed. For some of the more differing architectures (Sun Ultra AX) which have i8042-alike chips in them complete separate drivers may make sense as well.
-- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |