lkml.org 
[lkml]   [2001]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Change in add_gendisk() in 2.4.11-preXXX
On Fri, Oct 05, 2001 at 11:02:32AM -0700, John Byrne wrote:
>
> Cristoph,
>
> Looking in the Changelog for 2.4.11-pre, I find that you are given
> credit for the change to add_gendisk() which should prevent the
> /proc/paritions loop; which is good.

In fact it was Alan's fix, I just sent it to Linus 8)

> However, I was tracing the bug
> myself and come to the conclusion the culprit in my case was the "sd"
> driver. One of our systems has two different SCSI HBAs and this resulted
> in two calls to sd_finish() which results in the sd_gendisk structures
> being added twice and, hence, the loop. So, I am a little concerned that
> your change is covering up the problem so well, that the actual issue
> may not be addressed. Unfortunately, I don't understand the ins and outs
> of the SCSI and blkdev layers to suggest a fix for "sd".

If you look at the new add_gendisk structure it is clearly marked that
the new bahaviour is a workaround.

It will be fixed in 2.5, but the scsi layer is too fragile to do such
changes in 2.4.

Christoph

--
Of course it doesn't work. We've performed a software upgrade.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:04    [W:0.035 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site