Messages in this thread |  | | From | "Petr Vandrovec" <> | Date | Tue, 30 Oct 2001 21:21:57 MET-1 | Subject | Re: [PATCH] small compile warning fix |
| |
> > You can remove it completely. It should not be '#ifdef LATER', but > > '#ifdef OLDVERSION'... ncp_add_mem_fromfs was invoked with lock on > > ncp_server structure, but then it directly accessed userspace. It was > > possible to use this to cause deadlock, so now ncpfs uses bounce buffers > > and double copy instead of this. > > > > would you include this in your patches or would you like me to make > it #ifdef OLDVERSION ?
I removed ncp_add_mem_fromfs() from my tree...
> > I have some ncpfs patches, but I though that I'll leave them for 2.5.x. > > Maybe it is time to change this decision.
... but as diff between my ncpfs and Alan's is about 30KB, I still did not decide whether I'll send it for 2.4.x... Petr Vandrovec vandrove@vc.cvut.cz
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |