lkml.org 
[lkml]   [2001]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Re: all files are executable in vfat
Looking at linux/fs/fat/inode.c it seems that everything is
here to allow a smart handling of the x flag.
But there is something that I don't undestand (or is a bug)
and is corrected by this micro patch.

--- linux-2.4.10-xfs/fs/fat/inode.c Wed Sep 26 20:59:39 2001
+++ linux-2.4.10-xfs.fat_exec/fs/fat/inode.c Wed Sep 26 22:32:35 2001
@@ -920,8 +920,8 @@
inode->i_generation |= 1;
inode->i_mode = MSDOS_MKMODE(de->attr,
((sbi->options.showexec &&
- !is_exec(de->ext))
- ? S_IRUGO|S_IWUGO : S_IRWXUGO)
+ is_exec(de->ext))
+ ? S_IRWXUGO : S_IRUGO|S_IWUGO)
& ~sbi->options.fs_umask) | S_IFREG;
MSDOS_I(inode)->i_start = CF_LE_W(de->start);
if (sbi->fat_bits == 32) {

Now you have two choices when using umask=OOO
- without showexec : only dirs have the x flag set.
- with showexec : *.{exe,bat,com} have it too.
I am not the list so ...

Guillaume Chazarain
(putting my name in the header doesn't work.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.023 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site