lkml.org 
[lkml]   [2001]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] 2.4.13 remove unused warnings on module tables
Keith Owens wrote:
>
> On Mon, 29 Oct 2001 01:17:15 -0500,
> Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> >Keith Owens wrote:
> >> @@ -11,6 +11,7 @@
> >> #include <linux/spinlock.h>
> >> #include <linux/list.h>
> >>
> >> +#ifndef CONFIG_KBUILD_2_5
> >> #ifdef __GENKSYMS__
> >> # define _set_ver(sym) sym
> >> # undef MODVERSIONS
> >> @@ -21,6 +22,7 @@
> >> # include <linux/modversions.h>
> >> # endif
> >> #endif /* __GENKSYMS__ */
> >> +#endif /* CONFIG_KBUILD_2_5 */
> >>
> >> #include <asm/atomic.h>
> >>
> >> @@ -257,8 +259,6 @@ static const unsigned long __module_##gt
> >
> >I don't think we need this part of the patch.
>
> It is a small change to module.h that is required for kbuild 2.5 and
> has no effect on 2.4. Saves me having to send another patch later.

If everybody did this Linus would get 1001 unnecessary changes for 1002
patches...

Look, this isn't 2.5. Everyone else has to separate out their 2.5
patches. You're not special, you need to do it too... Let's actually
take another half-second when sending patches to make sure Linus only
gets the changes destined for 2.4. Keep the patch noise down, and help
out not only Linus but everyone else reviewing 2.4 code.

Jeff, keeper of tree purity


--
Jeff Garzik | Only so many songs can be sung
Building 1024 | with two lips, two lungs, and one tongue.
MandrakeSoft | - nomeansno

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:11    [W:0.040 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site