Messages in this thread |  | | Date | Sun, 28 Oct 2001 08:16:12 -0500 (EST) | From | Alexander Viro <> | Subject | Re: more devfs fun (Piled Higher and Deeper) |
| |
On Sun, 28 Oct 2001, Roman Zippel wrote:
> What about putting them somewhere in a CVS repository, so people can see > what's going on and maybe even can help out?
Looks like I'll get around to creating a CVS repository starting at the last known code in a couple of days anyway...
> BTW you should really do something about your coding style, your code is > very confusing to read. I wouldn't care if it would be just some driver, > but devfs is supposed to be a very important part, so it would be nice > to use the same rules that apply to other important parts of the kernel.
Good luck.
BTW, Richard - the last one for tonight:
devfs_unregister() vs. get_vfs_inode(). The latter blocks, so devfs_lookup() and devfs_d_revalidate() can give you a nasty surprise - entry gets unregistered while we allocate the inode and there's no connection between it and inode or dentry at that point. Then we merrily get dentry/inode tied to unregistered devfs_entry. And that includes reference _to_ dentry. Enjoy...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |