Messages in this thread Patch in this message |  | | Subject | Re: 2.4.14-pre3: some compilerwarnings... | From | Robert Love <> | Date | 27 Oct 2001 13:16:23 -0400 |
| |
On Sat, 2001-10-27 at 12:51, Sven Vermeulen wrote: > A little grep on the stdout/stderr of "make bzImage":
You can't do much about unused variables because, as you suggested, they may be present with a different config. For example, the unused attach_it label in super.c is used if NFS is defined.
As for the typecast error, we should fix that...the attached patch uses the typed min system macro. Linus, the attached is against 2.4.14-pre3. Please, apply.
diff -u linux-2.4.14-pre3/drivers/char/random.c linux/drivers/char/random.c --- linux-2.4.14-pre3/drivers/char/random.c Sat Oct 27 13:13:03 2001 +++ linux/drivers/char/random.c Sat Oct 27 13:13:52 2001 @@ -1245,8 +1245,9 @@ if (r->entropy_count < nbytes * 8 && r->entropy_count < r->poolinfo.POOLBITS) { - int nwords = min(r->poolinfo.poolwords - r->entropy_count/32, - sizeof(tmp) / 4); + int nwords = min_t(int, + r->poolinfo.poolwords - r->entropy_count/32, + sizeof(tmp) / 4); DEBUG_ENT("xfer %d from primary to %s (have %d, need %d)\n", nwords * 32,
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |