Messages in this thread |  | | Date | Fri, 26 Oct 2001 05:13:46 +0200 | From | David Weinehall <> | Subject | Re: SiS/Trident 4DWave sound driver oops |
| |
On Thu, Oct 25, 2001 at 10:42:04PM -0400, Robert Love wrote: > On Thu, 2001-10-25 at 22:36, Tachino Nobuhiro wrote: > > No. {0, } is the last elemnet of ac97_codec_ids[] and that index is > > ARRAY_SIZE(ac97_code_ids) - 1. So this element which should be used as > > a loop terminator is used as a valid entry in for loop incorrectly. > > > > Please read ac97_codec.c > > You are right; I apologize.
I think the way this is coded stinks anyway. the {0,} should be used as a loop-terminator, not ARRAY_SIZE(blaha) - 1. Yes, using 0-termination wastes space. But it's cleaner and in line with what most other code does.
/David Weinehall _ _ // David Weinehall <tao@acc.umu.se> /> Northern lights wander \\ // Project MCA Linux hacker // Dance across the winter sky // \> http://www.acc.umu.se/~tao/ </ Full colour fire </ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |