[lkml]   [2001]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: HPT370/366 testers needed
    On Tue, Oct 23, 2001 at 09:51:19AM -0700, Tim Hockin wrote:
    > All,
    > We have this (attached) large patch for the HighPoint driver.
    > Specifically, it deals with HPT370 controllers, and should make them MUCH
    > more stable (Adrian spent weeks on the phone with HighPoint).
    > What I'd like is for people to test this patch on other systems with
    > HighPoint 370 controllers. Also, I need people with HPT366 chips to test,
    > and find any problems - we don't have HPT366 here to test.

    > Volunteers?

    I don't have any HighPoint controllers here, but I did spot a bug in
    the patch that's easy to fix:

    > -#if 0
    > - if (test != 0x08)
    > - pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, 0x08);
    > -#else
    > if (test != (L1_CACHE_BYTES / 4))
    > pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, (L1_CACHE_BYTES / 4));
    > -#endif

    This isn't correct on current Athlon and P4 machines running kernels
    compiled for i686. One approach is to only set the cache line size if
    the bios set it to something less than we expect it to, or to leave
    this kind of pci hackery to the generic pci layer. It's important to
    note that quite a few drivers share this bug at present. Cheers,

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:18    [W:0.046 / U:4.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site