lkml.org 
[lkml]   [2001]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] binfmt_misc.c, kernel-2.4.12
Date
On Mon, 22 Oct 2001 04:33:27 -0400 (EDT), 
Alexander Viro <viro@math.psu.edu> wrote:
>On Mon, 22 Oct 2001, Keith Owens wrote:
>> If I can get an iron clad guarantee that binfmt_misc will never, ever
>> change again then I might consider hard coding the entries in modprobe.
>> BTW, I will need a signature in blood that says I can kill you if
>> binfmt_misc is ever changed :).
>
>Wait a second. Who says anything about hardcoding that into modprobe?
>There is such thing as skeleton stuff for modules.conf, right?

Same thing. The preset entries in modutils util/alias.h are added to
whatever the user has in modules.conf. In some cases the preset
entries cannot be removed, they are cumulative so the hard coded entry
cannot be removed.

The preset entries already causes problems, why should modutils insist
on options sb io=0x220 irq=7 dma=1 dma16=5 mpu_io=0x330?

>Erm... Keith, I might be misreading the source, but... Shouldn't the
>information like "block major $FOO is in module $BAR" live in
>/lib/modules/*/* ?

Historically the mapping of device majors to module or binary format
type to module was coded into modutils, via util/alias.h. That was a
mistake, it should have used the same technique as pci, isapnp, parport
etc., each module has a table that defines what it handles and modutils
extracts the data directly from the modules. Developers have changed
the names of their modules and now we have hard coded module names in
modutils that do not match the names used by some kernels. Hindsight
is wonderful!

In modutils 2.5 I will get rid of all the hard coded entries in
util/alias.h. Instead each module will define what it supports,
including any special commands to be run when the module is loaded or
unloaded. Much easier for everyone and far more flexible.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:18    [W:0.065 / U:20.224 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site