lkml.org 
[lkml]   [2001]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subjectsys_personality changes
From
Date

I'm curious about the purpose of the sys_personality changes that made
it into 2.4.10. In 2.4.9, it looked like this:

asmlinkage long sys_personality(unsigned long personality)
{
int ret = current->personality;
if (personality != 0xffffffff) {
set_personality(personality);
if (current->personality != personality)
ret = -EINVAL;
}
return ret;
}

Compared to your new one:

asmlinkage long
sys_personality(u_long personality)
{
if (personality == 0xffffffff)
goto ret;
set_personality(personality);
if (current->personality != personality)
return -EINVAL;
ret:
return (current->personality);
}

What was the purpose of changing the way sys_personality works? AFAIK
sys_personality is supposed to return the previous persona. Yours
returns the new persona instead.

Was this intended, or can we roll back this part of your patch?

Thanks,
Paul Larson

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:03    [W:0.037 / U:36.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site