Messages in this thread | | | Date | Fri, 19 Oct 2001 18:00:38 -0400 (EDT) | From | Alexander Viro <> | Subject | Re: [PATCH] binfmt_misc.c, kernel-2.4.12 |
| |
On Fri, 19 Oct 2001, Richard Guenther wrote:
> > Or, say it, one about meaning of > > if ((count == 1) && !(buffer[0] & ~('0' | '1'))) { > > not being the same as > > if (count == 1 && (buffer[0] == '0' || buffer[0] == '1')) { > > Err, who said that it is the same?? Its sufficient, if you trust > root to just pass '0' or '1'. Ok, its probably too clever for the > average C programmer, but it seems I didnt care.
If you trust root to pass '0' or '1' - (count == 1) would do nicely. And sorry, but "clever" is not the word that comes to mind. "Not having a clue on the meaning of bitwise operations" would be more accurate.
> > As for the version in -ac and maintaining it - sure I will. > > Just get Linus to take the -ac version then. I'm sick to read
<shrug> might be a good idea. The thing is extremely sloppy and considering the blatant "I'm t00 l33t t0 F1X 7h4t" attitude of maintainer...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |