[lkml]   [2001]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] binfmt_misc.c, kernel-2.4.12
On Fri, 19 Oct 2001, Alexander Viro wrote:

> On Fri, 19 Oct 2001, Richard Guenther wrote:
> > Hi Linus,
> >
> > As Al pissed me off again with complaining about binfmt_misc, please
> > apply the attached patch which corrects the 'not C code' line and
> > fixes the problem Albert noticed. This doesnt fix various assumptions
> > about the /proc code that were either valid at the time of writing
> > binfmt_misc or badly/not documented.

As binfmt_misc write access is root only, I didnt care to check
too much as root can shoot himself anyway. Some places could use
more checking, some even less.

> Or, say it, one about meaning of
> if ((count == 1) && !(buffer[0] & ~('0' | '1'))) {
> not being the same as
> if (count == 1 && (buffer[0] == '0' || buffer[0] == '1')) {

Err, who said that it is the same?? Its sufficient, if you trust
root to just pass '0' or '1'. Ok, its probably too clever for the
average C programmer, but it seems I didnt care.

> Please, learn C. Then learn some basic stuff about kernel programming.
> Then feel free to start mouthing off.

Well, try to get some basic communication style and you'll even
get a long with guys like me.

> As for the version in -ac and maintaining it - sure I will.

Just get Linus to take the -ac version then. I'm sick to read
your comments about binfmt_misc over and over again. You've
made your point(s) - more than one time. Thats enough. Welcome
to my killfile now.


Richard Guenther <>
PGP: 2E829319 - 2F 83 FC 93 E9 E4 19 E2 93 7A 32 42 45 37 23 57

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:08    [W:0.041 / U:4.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site