lkml.org 
[lkml]   [2001]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] binfmt_misc.c, kernel-2.4.12


On Fri, 19 Oct 2001, Richard Guenther wrote:

> Hi Linus,
>
> As Al pissed me off again with complaining about binfmt_misc, please
> apply the attached patch which corrects the 'not C code' line and
> fixes the problem Albert noticed. This doesnt fix various assumptions
> about the /proc code that were either valid at the time of writing
> binfmt_misc or badly/not documented.

Like, say it, "thou shalt not dereference user-supplied pointers for verily,
copy_from_user() is there for purpose"?

Or "tons of blind sprintf() calls can really ruin your day when you overflow
the buffer"?

Or that checking the values of arguments, while a noble thing, should
be done _before_ you use them?

Or, say it, one about meaning of
if ((count == 1) && !(buffer[0] & ~('0' | '1'))) {
not being the same as
if (count == 1 && (buffer[0] == '0' || buffer[0] == '1')) {
Darn that Ritchie guy - he should've documented that stuff. Oh, wait -
he had actually done that...

Please, learn C. Then learn some basic stuff about kernel programming.
Then feel free to start mouthing off.

As for the version in -ac and maintaining it - sure I will.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:08    [W:0.164 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site