Messages in this thread |  | | Date | Wed, 17 Oct 2001 15:53:19 +0200 | From | Peter Wächtler <> | Subject | Re: NFS related Oops in 2.4.[39]-xfs |
| |
Peter Wächtler wrote: > > Steve Lord wrote: > > > > Where did you get your kernel (the 2.4.9 version that is) this problem > > sounds familiar, but I am pretty sure we fixed this case in XFS somewhere > > between 2.4.3 and 2.4.9. > > > > The following diff was made in 2.4.4. > > diff -u --recursive --new-file v2.4.4/linux/fs/nfsd/nfsfh.c linux/fs/nfsd/nfsfh.c > --- v2.4.4/linux/fs/nfsd/nfsfh.c Fri Feb 9 11:29:44 2001 > +++ linux/fs/nfsd/nfsfh.c Sat May 19 17:47:55 2001 > @@ -244,6 +245,11 @@ > */ > pdentry = child->d_inode->i_op->lookup(child->d_inode, tdentry); > d_drop(tdentry); /* we never want ".." hashed */ > + if (!pdentry && tdentry->d_inode == NULL) { > + /* File system cannot find ".." ... sad but possible */ > + dput(tdentry); > + pdentry = ERR_PTR(-EINVAL); > + } > > But it would not prevent the code path 2.4.3-xfs hit. > pdentry is !=NULL and tdentry->d_inode is always NULL after d_alloc():611 >
Damn. pdentry IS NULL. Sorry, the patch would prevent the crash. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |