Messages in this thread |  | | Date | Sun, 14 Oct 2001 14:49:25 +0300 | From | Mika Liljeberg <> | Subject | Re: TCP acking too fast |
| |
Andi Kleen wrote: > The only special case for PSH in RX left I can is in rcv_mss estimation, > where is assumes that a packet with PSH set is not full sized.
A packet without PSH should be full size. Assuming the sender implemets SWS avoidance correctly, this should be a safe enough assumption.
> On further > look the 2.4 tcp_measure_rcv_mss will never update rcv_mss for packets > which do have PSH set and in this case cause random ack behaviour depending > on the initial rcv_mss guess. > Not very nice; definitely violates the "be conservative what you accept" > rule. I'm not sure how to fix it, adding a fallback to every-two-packet-add > would pollute the fast path a bit.
You're right. As far as I can see, it's not necessary to set the TCP_ACK_PUSHED flag at all (except maybe for SYN-ACK). I'm just writing a patch to clean this up.
> -Andi
Regards,
MikaL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |