lkml.org 
[lkml]   [2001]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: crc32 cleanups
Date
On Fri, 12 Oct 2001 14:37:52 -0500 (CDT), 
Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
>(linux/lib/Makefile)
>obj-$(CONFIG_TULIP) += crc32.o
>obj-$(CONFIG_NATSEMI) += crc32.o
>obj-$(CONFIG_DMFE) += crc32.o
>obj-$(CONFIG_ANOTHERDRIVER) += crc32.o

It is better to define CONFIG_CRC32 and have the Config.in files set
CONFIG_CRC32 for selected drivers. That avoids the problem of lots of
drivers wanting to patch the same Makefile, instead the selection of
crc32 is kept with the driver selection.

lib/Makefile
obj-$(CONFIG_CRC32) += crc32.o

drivers/foo/Config.in
if [ "$CONFIG_FOO" = "y" ]; then
define_bool CONFIG_CRC32 y
fi

It is even cleaner in CML2.
require FOO implies CRC32=y

In general it is a bad idea to handle selections in the Makefile, that
is what CML is for. Makefiles should just build the code based on CML
output, not try to decide what to build.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:08    [from the cache]
©2003-2011 Jasper Spaans