Messages in this thread |  | | Date | Fri, 12 Oct 2001 14:37:52 -0500 (CDT) | From | Jeff Garzik <> | Subject | Re: crc32 cleanups |
| |
More comments: * if ether_crc is always == ether_crc_be, then create a #define instead of patching driver code * no need to inline ether_crc_be, stick it in lib/crc32.c also * using a ref-counting init_crc32 and cleanup_crc32, you do not need CONFIG_xxx tests, per driver, in the code itself. Either make lib/crc32 a permanent part of the kernel, or make it a separate module which is enabled by makefile rules. Example:
(linux/lib/Makefile) obj-$(CONFIG_TULIP) += crc32.o obj-$(CONFIG_NATSEMI) += crc32.o obj-$(CONFIG_DMFE) += crc32.o obj-$(CONFIG_ANOTHERDRIVER) += crc32.o
makefile rules eliminate the duplicates...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |