Messages in this thread |  | | Subject | Re: kapm-idled Funny in 2.4.10-ac12 | From | Thomas Hood <> | Date | 12 Oct 2001 15:40:24 -0400 |
| |
Just taking a walk through apm.c ...
I notice that set_time() calls get_cmos_time() with interrupts disabled, whereas get_time_diff calls it with interrupts enabled.
get_cmos_time is in time.c . It does a bunch of CMOS_READs without taking rtc_lock.
Methinks that the save_flags(flags); ...; cli(); ...; restore_flags(flags); constructs in apm.c need some attention.
Thomas
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |