lkml.org 
[lkml]   [2001]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Unconditional include of <linux/module.h> in aic7xxx driver
On Thu, 11 Oct 2001, Justin T. Gibbs wrote:
> So, in theory I could nuke many of the remaining "#ifdef MODULE"'s?

yes. most if not all.


> This wasn't done in the aic7xxx driver for 2.4.12. My only concern with
> doing this is having the driver still work on older kernel versions.

Define "older" :) Even 2.2 kernels have worked this way for a while, so
it really depends on how far you want to go back. I think this policy
started in late 2.1.xx days IIRC.

Also, WRT older kernel compatibility, look at drivers/net/acenic.c or
the kcompat24 toolkit. These, and other code, illustrate how to be
compatible with older kernels without loading the source code down with
ifdefs. The basic idea is to provide a 2.4-like API on older kernels,
using macros and inline functions hidden in a compatibility header.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:08    [W:0.040 / U:20.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site