[lkml]   [2001]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: Compile Filure on 2.4.10-ac10+preempt+smp
On Wed, 2001-10-10 at 00:46, Mike Fedyk wrote:
> Fail 2.4.10-ac10+preempt+smp
> Success 2.4.10-ac10+preempt+up-apic+up-ipapic
> Success 2.4.10-ac10+preempt
> Success 2.4.10-ac10
> Robert, can you do a test compile for smp just in case?

Ahh, yes. Thank you for spotting this. include/asm-i386/spinlock.h has
two separate defines for spin_unlock and we only renamed one of them. I
guess you hit the conditional that used the other define...

The attached patch fixes it.

> Also, I couldn't find any links to old patches on your web site...
> [...]

I only keep around patches to the last official kernel, plus the latest
-pre and -ac I patched. Since the patch itself is being updated, its a
pain to backport to older kernels.

--- linux-2.4.10-ac10/include/asm-i386/spinlock.h.orig Mon Oct 8 18:33:10 2001
+++ linux-2.4.10-ac10/include/asm-i386/spinlock.h Wed Oct 10 01:08:47 2001
@@ -97,7 +97,7 @@
:"=q" (oldval), "=m" (lock->lock) \
:"0" (1) : "memory"

-static inline void spin_unlock(spinlock_t *lock)
+static inline void _raw_spin_unlock(spinlock_t *lock)
char oldval;

Robert Love

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:05    [W:0.051 / U:4.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site