Messages in this thread Patch in this message |  | | Date | Wed, 10 Oct 2001 20:06:19 -0700 | From | Tom Rini <> | Subject | Re: Linux 2.4.10-ac11 |
| |
On Thu, Oct 11, 2001 at 12:16:17AM +0100, Alan Cox wrote:
> 2.4.10-ac11 [snip] > o Blink keyboard lights on panic on x86 (Andi Kleen)
I _suspect_ this is what caused drivers/char/pc_keyb.c to depend on <linux/pm.h>. This works on x86 because <asm-i386/keyboard.h> includes <linux/pm.h>. The inlined moves the include to pc_keyb.c so that other arches compile fine. I also _think_ nothing else needs the include in <asm-i386/keyboard.h> so kill that off too.
-- Tom Rini (TR1265) http://gate.crashing.org/~trini/
--- linux-2.4.10-ac11.orig/drivers/char/pc_keyb.c Wed Oct 10 19:10:27 2001 +++ linux-2.4.10-ac11/drivers/char/pc_keyb.c Wed Oct 10 19:35:15 2001 @@ -34,6 +34,7 @@ #include <linux/vt_kern.h> #include <linux/smp_lock.h> #include <linux/kd.h> +#include <linux/pm.h> #include <asm/keyboard.h> #include <asm/bitops.h> --- linux-2.4.10-ac11.orig/include/asm-i386/keyboard.h Wed Oct 10 19:10:50 2001 +++ linux-2.4.10-ac11/include/asm-i386/keyboard.h Wed Oct 10 19:35:09 2001 @@ -16,7 +16,6 @@ #include <linux/kernel.h> #include <linux/ioport.h> #include <linux/kd.h> -#include <linux/pm.h> #include <asm/io.h> #define KEYBOARD_IRQ 1 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |