lkml.org 
[lkml]   [2001]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] 2.4.11 min() in tcp.c
From
   From: Chris Wright <chris@wirex.com>
Date: Wed, 10 Oct 2001 16:44:30 -0700

tcp.c:855: warning: comparison of distinct pointer types lacks a cast

the following patch, changes min() to min_t() to make size_t explicit.

Applied, but with a cleanup, please never do this:

- min(
+ min_t (

"min_t" is not a C operator, therefore no reason to put a space
between "min_t" and the openning parenthesis. If you look around,
this is the general coding style rule the Linux code follows:

if () /* <--- space here */
while () /* <--- and here */
foo_function() /* <--- but not here */

For example.

Franks a lot,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:08    [W:0.057 / U:3.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site