lkml.org 
[lkml]   [2001]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH]Fix bug:rmdir could remove current working directory
Hi Linus, Alan and Al,

I found that rmdir(2) could remove current working directory
successfully. This happens when the given pathname points to current
working directory, not ".", but something else. For example, the current
working directory's absolute pathname. I read the man page of
rmdir(2). It says in this case EBUSY error should be returned. I
suspected this is a bug and added a check in vfs_rmdir(). The following
patch is against 2.4.10 and has been verified. Please comment and
apply.

--
Mingming Cao

--- linux-2.4.10/fs/namei.c Tue Sep 18 11:01:47 2001
+++ /home/ming/linux-tk/fs/namei.c Tue Oct 9 11:58:50 2001
@@ -1362,6 +1362,8 @@
error = -ENOENT;
else if (d_mountpoint(dentry))
error = -EBUSY;
+ else if (dentry == current->fs->pwd)
+ error = -EBUSY;
else {
lock_kernel();
error = dir->i_op->rmdir(dir, dentry);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:08    [W:0.067 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site