lkml.org 
[lkml]   [2001]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Subtle MM bug - 2 errors in MM code in pre-2.4.1?
Hi - 
Based on my quick reading of this patch:
+
+empty:
+ spin_lock(&mmlist_lock);
+ return 0;

The above should actually be spin_UNlock?

Also the test for !inactive_shortage() seems to be inverted?

+ /* If refill_inactive_scan failed, try to page stuff out.. */
+ swap_out(priority, gfp_mask);
+ } while (!inactive_shortage());

-BenRI
--
"...assisted of course by pride, for we teach them to describe the
Creeping Death, as Good Sense, or Maturity, or Experience."
- "The Screwtape Letters"
Benjamin Redelings I <>< http://www.bol.ucla.edu/~bredelin/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.028 / U:5.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site