[lkml]   [2001]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] cramfs is ro only, so honour this in inode->mode
Hi Linus,
hi all,

cramfs is a read-only fs. So we should honour that in inode->mode
to avoid confusion of programs.

My isofs shows this too, so I think I'm right deleting the write
permissions in the inode. May be we should change it in
mkcramfs (too).

I don't know what POSIX says about RO fs, but I can't find any
real sense in having W permissions for an RO fs.

The patch:
--- linux-2.4.0/fs/cramfs/inode.c.orig Fri Dec 29 23:07:57 2000
+++ linux-2.4.0/fs/cramfs/inode.c Mon Jan 8 13:04:37 2001
@@ -37,7 +37,7 @@
struct inode * inode = new_inode(sb);

if (inode) {
- inode->i_mode = cramfs_inode->mode;
+ inode->i_mode = cramfs_inode->mode & ~ S_IWUGO;
inode->i_uid = cramfs_inode->uid;
inode->i_size = cramfs_inode->size;
inode->i_gid = cramfs_inode->gid;

Ingo Oeser
10.+11.03.2001 - 3. Chemnitzer LinuxTag <>
<<<<<<<<<<<< come and join the fun >>>>>>>>>>>>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:52    [W:0.065 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site