lkml.org 
[lkml]   [2001]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.0 tulip bug (was: And oh, btw..)
On Fri, Jan 05, 2001 at 04:23:13PM +0100, Mikael Pettersson wrote:
> >Changes since the prerelease:
> >...
> >Matti Aarnio:
> > - teach tulip driver about media types 5 and 6
>
> This part of the patch introduces a bug in 2.4.0, as noticed by gcc:

Oddly enough the beast works with my test specimen,
but real analysis is still incomplete by Donald et.al.

So far we think that if the card has MII (type 1) media,
it could safely ignore types 5 and 6.

> The patch also adds four unused variables, which looks rather fishy.

Indeed, it is copy&paste from somewhere else, which may
indeed have different control flows.

However unless you have esoteric (taiwanese) special hardware
with those media types, it won't affect you.

> /Mikael

/Matti Aarnio
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.028 / U:1.188 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site