Messages in this thread |  | | Date | Fri, 5 Jan 2001 17:38:08 +0200 | From | Matti Aarnio <> | Subject | Re: 2.4.0 tulip bug (was: And oh, btw..) |
| |
On Fri, Jan 05, 2001 at 04:23:13PM +0100, Mikael Pettersson wrote: > >Changes since the prerelease: > >... > >Matti Aarnio: > > - teach tulip driver about media types 5 and 6 > > This part of the patch introduces a bug in 2.4.0, as noticed by gcc:
Oddly enough the beast works with my test specimen, but real analysis is still incomplete by Donald et.al.
So far we think that if the card has MII (type 1) media, it could safely ignore types 5 and 6.
> The patch also adds four unused variables, which looks rather fishy.
Indeed, it is copy&paste from somewhere else, which may indeed have different control flows.
However unless you have esoteric (taiwanese) special hardware with those media types, it won't affect you.
> /Mikael
/Matti Aarnio - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |