lkml.org 
[lkml]   [2001]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Happy new year^H^H^H^Hkernel..
From
Date
Russell King <rmk@arm.linux.org.uk> writes:

> Kai Germaschewski writes:
> > The patch is right, the explanation was wrong. Sorry, I didn't CC l-k when
> > I found what was really going on. Other source files used a global
> > initialized variable "divert_if" as well, so this became the same one as
> > the one referenced in isdn_common.c. That's why it wasn't zero, it was
> > explicitly initialized elsewhere. However, making divert_if static in
> > isdn_common.c fixes the problem, because now it's really local to this
> > file and therefore initialized to NULL.
>
> Maybe someone should compile the kernel with everything built in and
> -fno-common to catch stuff like this? Maybe we should always compile
> the kernel with -fno-common?

Sounds good.

We probably need to wait until after 2.4.0 is released to make the
change though.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.052 / U:8.676 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site