lkml.org 
[lkml]   [2001]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Ext2-devel] Re: [RFC] ext2_new_block() behaviour
Hi,

On Wed, Jan 03, 2001 at 11:12:48AM -0500, Alexander Viro wrote:
>
> On Wed, 3 Jan 2001, Stephen C. Tweedie wrote:
>
> > Having preallocated blocks allocated immediately is deliberate:
> > directories grow slowly and remain closed most of the time, so the
> > normal preallocation regime of only preallocating open files and
> > discarding preallocation on close just doesn't work.
>
> Erm. For directories we would not have the call of discard_prealloc()
> on close(2) - they have NULL ->release() anyway and for them it would
> happen only on ext2_put_inode(), i.e. upon the final dput(). Which would
> not happen while some descendent would stay in dcache.
>
> IOW, if directory is really going to grow (which normally mean that we
> are busily writing into files in it or its subdirectories) we will not
> get discard_prealloc() until it's all over.

The problem with directories is that they don't always grow rapidly
like that. Spool directories are perfect examples of directories
which grow sporadically over a long time, which is why we wanted
persistent preallocation.

The most common instance where that happens to regular files is the
case of log files, but those tend to be held open even while idle so
the preallocation persists anyway.

--Stephen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:52    [W:0.118 / U:5.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site