[lkml]   [2001]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] filemap_fdatasync & related changes

On Thursday, January 04, 2001 10:48:13 AM +0100 Christoph Rohland
<> wrote:

> Chris Mason <> writes:
>> Just noticed the filemap_fdatasync code doesn't check the return value
>> from writepage. Linus, would you take a patch that redirtied the page,
>> puts it back onto the dirty list (at the tail), and unlocks the page
>> when writepage returns 1?
>> That would loop forever if the writepage func kept returning 1 though...I
>> think that's what we want, unless someone like ramfs made a writepage
>> func that always returned 1.
> shmem has such a writepage for locked shm segments. It also always
> return 1 if the swap space is exhausted. So everybody using shared
> anonymous, SYSV shared or POSIX shared memory can hit this.
> I invented the return code 1 exactly to be able to handle this.

Yes, right now the shmem writepage calls are the only ones returning one at
all. But, the question of how to properly fsync/msync these kinds of pages
still stands. Returning from an fsync before writing them isn't correct.

Either way, filemap_fdatasync needs fixing, since it drops the dirty bit on
these pages. They'll never get written after going through it.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:52    [W:0.113 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site