[lkml]   [2001]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] filemap_fdatasync & related changes

On 4 Jan 2001, Christoph Rohland wrote:

> Chris Mason <> writes:
> > Just noticed the filemap_fdatasync code doesn't check the return value from
> > writepage. Linus, would you take a patch that redirtied the page, puts it
> > back onto the dirty list (at the tail), and unlocks the page when writepage
> > returns 1?
> >
> > That would loop forever if the writepage func kept returning 1 though...I
> > think that's what we want, unless someone like ramfs made a writepage func
> > that always returned 1.
> shmem has such a writepage for locked shm segments.

The correct thing seems to be wait for this lock in case of
fdatasync/sync/etc, then.

What about a sync parameter to ->writepage() ?

> return 1 if the swap space is exhausted. So everybody using shared
> anonymous, SYSV shared or POSIX shared memory can hit this.

In case of swap exhausted I think we should just fail.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:52    [W:0.110 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site