lkml.org 
[lkml]   [2001]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    > And one more point for the Janitor's list:
    > Get rid of superflous irqsave()/irqrestore()'s - in 90% of the cases
    > either spin_lock_irq() or spin_lock() is sufficient. That's both faster
    > and better readable.

    Expect me to drop any submissions that do this. I'd rather take the two
    clock hit in most cases because the effect of spin_lock_irq() being used
    and people then changing which functions call each other and producing
    impossible to debug irq mishandling cases is unacceptable.

    The original Linux network code did this with sti() not save/restore flags.
    I've been there before, I am not going to allow a rerun of that disaster for
    a few cycles

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:16    [W:0.020 / U:128.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site