Messages in this thread Patch in this message |  | | Date | Sat, 03 Feb 2001 01:43:45 -0600 | From | Anwar Payyoorayil <> | Subject | [PATCH] 2.4.0-prerelease-ac4: i810_audio.c: Alternate VRA fix |
| |
Alan -
Based on your suggestion, I looked again, and found that even though the kernel sets VRA, the bit is lost when the driver unnecessarily resets the CODEC. The patch below removes the unnecessary resetting of the CODEC. Nothing seems to be lost by removing the resetting, and the driver in 2.2 series (where VRA works fine) does not do this reset.
If we find that somebody needs this reset, we can move the VRA enabling code after the codec reset code.
Anwar.
Patch against 2.4.0-prerelease-ac4
--- linux/drivers/sound/i810_audio.c.ac4 Sat Feb 3 01:26:31 2001 +++ linux/drivers/sound/i810_audio.c Sat Feb 3 01:26:54 2001 @@ -1898,11 +1898,6 @@ pci_dev->driver_data = card; pci_dev->dma_mask = I810_DMA_MASK; -// printk("resetting codec?\n"); - outl(0, card->iobase + GLOB_CNT); - udelay(500); -// printk("bringing it back?\n"); - outl(1<<1, card->iobase + GLOB_CNT); return 0; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |