[lkml]   [2001]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Ext2-devel] Re: [RFC] ext2_new_block() behaviour

On Wed, 3 Jan 2001, Stephen C. Tweedie wrote:

> Having preallocated blocks allocated immediately is deliberate:
> directories grow slowly and remain closed most of the time, so the
> normal preallocation regime of only preallocating open files and
> discarding preallocation on close just doesn't work.

Erm. For directories we would not have the call of discard_prealloc()
on close(2) - they have NULL ->release() anyway and for them it would
happen only on ext2_put_inode(), i.e. upon the final dput(). Which would
not happen while some descendent would stay in dcache.

IOW, if directory is really going to grow (which normally mean that we
are busily writing into files in it or its subdirectories) we will not
get discard_prealloc() until it's all over. open()/close() has nothing
to it - even if we used the same ->release() as for files, it would be
a no-op since all opens are read-only. Even for normal files close() after
read-only open() doesn't do anything to preallocation.

Comments? I'm not saying that it's necessary a good idea, but the argument
about file-like preallocation regime really doesn't apply - regime will
be different anyway...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:52    [W:0.054 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site