lkml.org 
[lkml]   [2001]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Linux 2.2.16 through 2.2.18preX TCP hang bug triggered by rsync

Andi Kleen writes:
> > BSD and Solaris both make these kinds of packets, therefore it is must
> > to handle them properly. So we will fix Linux, there is no argument.
>
> How do you propose to handle them? Queue the data anyways or just process
> the ACK?

tcp_sequence returns two flag bits instead of it's current binary
state. One bit says "accept data", the other says "accept control
bits" (such as RST, ACK, etc.)

tcp_sequence also will truncate the data len of the SKB area if
necessary, BSD really puts total crap in the probe byte.

Callers of tcp_sequence check the return value bits accordingly.
This is all slow path code, so there are no performance issues.

Later,
David S. Miller
davem@redhat.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.066 / U:71.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site