Messages in this thread | | | Date | Sat, 13 Jan 2001 14:24:54 +1100 | From | Andrew Morton <> | Subject | Re: QUESTION: Network hangs with BP6 and 2.4.x kernels, hardware |
| |
Linus Torvalds wrote: > > I'm also nervous about the complete lack of locking in vortex_timer(): > disabling interrupts doesn't mean that transmits couldn't be > pending. But maybe the hardware is ok with changing status concurrently. >
mm.. It's a little racy wrt vortex_ioctl(), but otherwise OK. del_timer_sync() in vortex_ioctl() seems to be needed.
disable_irq() is very useful in functions such as this. It would be a shame to have to stop using it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |