lkml.org 
[lkml]   [2001]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Compatibility issue with 2.2.19pre7
From
Date
>>>>> " " == Trond Myklebust <trond.myklebust@fys.uio.no> writes:

> - if (file->f_handle.fh_dcookie == fh->fh_dcookie &&
> - !memcmp(&file->f_handle, fh, sizeof(*fh)))
> + if (file->f_handle.fh_dcookie == fh.fh_dcookie &&
> + !memcmp(&file->f_handle, &fh, sizeof(fh)))
> goto found;

Come to think of it, this line looks pretty insane. Why on earth are
we testing fh_dcookie twice?

I suspect that just the elimination of the redundant comparison in the
above line would eliminate Russell's problem entirely, given that it's
the only place in the entire routine where we actually reference
fh->fh_base.fb_dentry.

In all other cases, we're referencing ordinary integers. Are there any
alignment requirements on them?

Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.101 / U:3.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site