lkml.org 
[lkml]   [2001]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] More compile warning fixes for 2.4.0
    On 9 Jan 2001, at 23:10, Linus Torvalds wrote:

    >
    >
    > On Wed, 10 Jan 2001, Andrea Arcangeli wrote:
    >
    > > On Tue, Jan 09, 2001 at 01:31:35PM -0800, Linus Torvalds wrote:
    > > > don't have to worry about undocumented extensions etc.
    > >
    > > Infact I don't blame gcc maintainers for that, but the standard. Ok, minor
    > > issue.
    >
    > Yeah, and nothing we can do about it any more.. Oh, well.
    >
    > The fact is that the
    >
    > case xxx: ;
    >
    > syntax is fairly ugly, so I'd prefer the fixup patches to look more like
    >
    > case xxx:
    > /* fallthrough */ ;
    > }
    >
    > or something (or maybe just a "break" statement), just so that we don't
    > turn the poor C language into line noise (can anybody say "perl" ;)
    >
    > I have to say, I think it was Pascal had this "no semicolon needed before
    > an 'end'" rule, and I always really hated that. The C statement rules make
    > a lo tmore sense, and requiring a statement after a case statement is
    > probably a very good requirement from a language standpoint. It's just not
    > very pretty - but adding a break or a comment will at least separate out
    > the colon and the semi-colon a bit.
    >
    > Linus
    >
    > -
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > Please read the FAQ at http://www.tux.org/lkml/

    I'll redo my patch to use break; and then I'll resend it.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:28    [W:0.022 / U:0.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site