lkml.org 
[lkml]   [2001]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] More compile warning fixes for 2.4.0


On Wed, 10 Jan 2001, Marco Colombo wrote:
> >
> > case xxx:
> > /* fallthrough */ ;
> > }
> >
> > or something (or maybe just a "break" statement), just so that we don't
> > turn the poor C language into line noise (can anybody say "perl" ;)
>
> Of course, you don't mean that the fallthrough comment and the break
> statement have the same functionality! (well you put the closing
> bracket and I agree that for the last case it's the same).

Note that the warning case we're discussing was really only about case
statements at the end of a compound statement.

In the middle of compound statements we're already fine: it's only the
corner case of a case "statement" without the statement that gcc
historically used to accept without warning, and that the gcc people only
recently noticed that they really shouldn't accept at all.

So that's why a comment and a "break" is equivalent. ONLY for the special
case of the new compile warning, though, obviously (see the subject line,
but yes, I should have made that more explicit).

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [from the cache]
©2003-2011 Jasper Spaans