lkml.org 
[lkml]   [2000]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] alignment issue with ipchains
On Sat, Sep 09, 2000 at 03:03:27PM +0900, NIIBE Yutaka wrote:
> - }
> + if (optname == IP_PKTINFO || optname == IP_RECVTTL
> + || optname == IP_RECVTOS || optname == IP_RECVOPTS
> + || optname == IP_RETOPTS || optname == IP_TOS
> + || optname == IP_TTL || optname == IP_HDRINCL
> + || optname == IP_MTU_DISCOVER || optname == IP_RECVERR
> + || optname == IP_MULTICAST_TTL || optname == IP_MULTICAST_LOOP
> + || optname == IP_ROUTER_ALERT)


This is ugly. I guess using a small table would be smaller and cleaner,
or alternatively just use a copy_from_user [would be the best solution
imho]

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.044 / U:50.488 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site