Messages in this thread |  | | Date | Wed, 06 Sep 2000 17:25:18 -0400 | From | Jeff Garzik <> | Subject | Re: [patch-2.4.0-test8-pre5] bugfixes for rtc driver (fwd) |
| |
Tigran Aivazian wrote: > > sorry, I've done it again... > > ---------- Forwarded message ---------- > Date: Wed, 6 Sep 2000 21:29:20 +0100 (BST) > From: Tigran Aivazian <tigran@veritas.com> > To: Linus Torvalds <torvalds@transmeta.com> > Cc: linux-kernel@vger.rutgers.edu > Subject: [patch-2.4.0-test8-pre5] bugfixes for rtc driver > > Hi Linus, > > The rtc driver does: > > a) not handle failures from misc_register() gracefully > > b) not handle failures from create_proc_read_entry() gracefully > > c) uses check_region() where request_region() would suffice > > The patch below fixes these issues/bugs.
Looks ok. One comment is that you should propagate any valid return values too, such as the request_irq or misc_register return value.
Jeff
-- Jeff Garzik | "I can't die until the government Building 1024 | finds a safe place to bury my liver." MandrakeSoft, Inc. | -- Phil Harris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |