lkml.org 
[lkml]   [2000]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch-2.4.0-test8-pre5] bugfixes for rtc driver (fwd)
Tigran Aivazian wrote:
>
> sorry, I've done it again...
>
> ---------- Forwarded message ----------
> Date: Wed, 6 Sep 2000 21:29:20 +0100 (BST)
> From: Tigran Aivazian <tigran@veritas.com>
> To: Linus Torvalds <torvalds@transmeta.com>
> Cc: linux-kernel@vger.rutgers.edu
> Subject: [patch-2.4.0-test8-pre5] bugfixes for rtc driver
>
> Hi Linus,
>
> The rtc driver does:
>
> a) not handle failures from misc_register() gracefully
>
> b) not handle failures from create_proc_read_entry() gracefully
>
> c) uses check_region() where request_region() would suffice
>
> The patch below fixes these issues/bugs.

Looks ok. One comment is that you should propagate any valid return
values too, such as the request_irq or misc_register return value.

Jeff




--
Jeff Garzik | "I can't die until the government
Building 1024 | finds a safe place to bury my liver."
MandrakeSoft, Inc. | -- Phil Harris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:45    [W:0.084 / U:70.920 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site