Messages in this thread | | | Date | Sat, 30 Sep 2000 17:37:35 +0200 | From | "Andi Kleen" <> | Subject | Re: Anyone working on multi-threaded core files for 2.4 ? |
| |
On Sat, Sep 30, 2000 at 03:45:54PM +0100, James Cownie wrote: > Since the Villarreal patch exists and seems to do all that I wanted, I > don't propose to create a competing patch. > > Maybe you kernel gurus could point out any problems with the Villarreal > approach ?
The patch assumes that all threads have the same pgrp (may be not true)
When other threads do not actually coredump or have the same pgrp then the tcore structure will never be cleaned up as far as I can see, allowing a nice DoS attack of filling your memory completely.
There was also another patch from Philip Gladstone for 2.2 BTW which did the same thing, but also had various problems. It worked around that particular trap by implementing the killing of other threads in kernel space (which is fine for Linux Threads, but limits other otherwise useful applications of clone threads). I think it had some other problems too.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |