Messages in this thread Patch in this message |  | | Date | Fri, 29 Sep 2000 03:42:27 -0500 (CDT) | From | Jeff Garzik <> | Subject | Re: [PATCH] esssolo1.c: get rid of check_region |
| |
I think we want to move request_region from xxx_open() to the probe stage....
Thomas, is there a reason for having the OPL3 region check in the xxx_open syscall?
Jeff
On Tue, 26 Sep 2000, Arnaldo Carvalho de Melo wrote:
> Hi, > > Please apply. > > - Arnaldo > > --- linux-2.4.0-test9-7/drivers/sound/esssolo1.c Mon Sep 25 23:31:33 2000 > +++ linux-2.4.0-test9-7.acme/drivers/sound/esssolo1.c Tue Sep 26 22:01:17 2000 > @@ -2085,12 +2085,11 @@ > return -ERESTARTSYS; > down(&s->open_sem); > } > - if (check_region(s->sbbase, FMSYNTH_EXTENT)) { > + if (!request_region(s->sbbase, FMSYNTH_EXTENT, "ESS Solo1")) { > up(&s->open_sem); > printk(KERN_ERR "solo1: FM synth io ports in use, opl3 loaded?\n"); > return -EBUSY; > } > - request_region(s->sbbase, FMSYNTH_EXTENT, "ESS Solo1"); > /* init the stuff */ > outb(1, s->sbbase); > outb(0x20, s->sbbase+1); /* enable waveforms */ > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > Please read the FAQ at http://www.tux.org/lkml/ >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |