lkml.org 
[lkml]   [2000]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.2.x Isdn init function fix
On Thu 28 Sep 2000, Luca Montecchiani wrote:

> Init function for hisax driver cause a kernel hangup if the
> idstring was omitted

Good catch.

> - if (strlen(str)) {
> + if (str) {

I'd make this:

+ if (str && *str) {

to preserve the intention of the original code
(the string mustn't be empty).

> - if (strlen(str)) {
> + if (str) {

ditto


Paul Slootman
--
home: paul@wurtel.demon.nl http://www.wurtel.demon.nl/
work: paul@murphy.nl http://www.murphy.nl/
debian: paul@debian.org http://www.debian.org/
isdn4linux: paul@isdn4linux.de http://www.isdn4linux.de/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.021 / U:1.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site