Messages in this thread |  | | Date | Fri, 29 Sep 2000 11:14:58 +0200 (MET DST) | From | "Maciej W. Rozycki" <> | Subject | Re: [patch] enabling APIC and NMI watchdog on UP systems |
| |
On Thu, 28 Sep 2000, Ingo Molnar wrote:
> the attached patch (against test9-pre7) is a cleaned up version Keir > Fraser's APIC-on-UP patch, and adds the enabling code of Keith Owens which > programs P6 performance counter 0 as an NMI. (i simplified the code alot - > there is no problem at all with getting NMIs from two sources, and it's > not necessary to make it configurable.)
I don't like your changes to connect_bsp_APIC() and the semantics of pic_mode. As the PIC mode is only meaningful for i82489DX configurations, it is irrelevant to integrated APIC implementations which your patch addresses. Please leave the i82489DX path unchanged -- it's too fragile.
Maciej
-- + Maciej W. Rozycki, Technical University of Gdansk, Poland + +--------------------------------------------------------------+ + e-mail: macro@ds2.pg.gda.pl, PGP key available +
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |