lkml.org 
[lkml]   [2000]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patches in this message
/
Date
From
Subject[PATCH] 2.2.x Isdn init function fix
Hi !

Init function for hisax driver cause a kernel hangup if the
idstring was omitted

"hisax=18,2" hang on boot
"hisax=18,2,HiSax" was fine

Kernel 2.4.x and modularized hisax was fine as well.

--- linux/drivers/isdn/hisax/config.c.orig Wed May 10 15:26:11 2000
+++ linux/drivers/isdn/hisax/config.c Thu Sep 28 22:48:44 2000
@@ -619,7 +619,7 @@
}
i++;
}
- if (strlen(str)) {
+ if (str) {
strcpy(HiSaxID, str);
HiSax_id = HiSaxID;
} else {

Grepping the whole kernel I also spot another possible place:

--- linux/drivers/isdn/icn/icn.c.orig Thu Sep 28 22:50:55 2000
+++ linux/drivers/isdn/icn/icn.c Thu Sep 28 22:51:13 2000
@@ -1869,7 +1869,7 @@
portbase = ints[1];
if (ints[0] > 1)
membase = ints[2];
- if (strlen(str)) {
+ if (str) {
strcpy(sid, str);
icn_id = sid;
if ((p = strchr(sid, ','))) {
--
------------------------------------------------------------------
E-mail......: Luca Montecchiani <m.luca@iname.com>
W.W.W.......: http://i.am/m.luca - http://luca.myip.org
Speakfreely.: sflwl -hlwl.fourmilab.ch luca@
I.C.Q.......: 17655604
-----------------------=(Linux since 1995)=-----------------------
Non esiste vento favorevole per il marinaio che non sa dove andare
Seneca


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.074 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site