[lkml]   [2000]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectPATCH fix PCI class test in ide-pci.c
My laptop reports that its IDE interface is PCI_CLASS_STORAGE_IDE,
but the code which tests for this looks all screwed up.

I changed the test as shown by the below patch, which looks like an
obviously correct fix to me.

When tested on my laptop, I now get
VP_IDE: bad irq(0): will probe later

Looking at lspci, my IDE interface doesn't report its IRQ directly via
the PCI interface, so this message looks correct (if a bit ominous).


Index: drivers/ide/ide-pci.c
RCS file: /usr/jgarzik/cvslan/linux_2_3/drivers/ide/ide-pci.c,v
retrieving revision
diff -u -r1.1.1.8 ide-pci.c
--- drivers/ide/ide-pci.c 2000/07/28 05:04:35
+++ drivers/ide/ide-pci.c 2000/09/27 08:37:47
@@ -538,7 +538,7 @@
* Can we trust the reported IRQ?
pciirq = dev->irq;
- if ((dev->class & ~(0xfa)) != ((PCI_CLASS_STORAGE_IDE << 8) | 5)) {
+ if ((dev->class & ~(0xff)) != (PCI_CLASS_STORAGE_IDE << 8)) {
printk("%s: not 100%% native mode: will probe irqs later\n", d->name);
* This allows offboard ide-pci cards the enable a BIOS,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:38    [W:0.048 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site