Messages in this thread |  | | Date | Mon, 25 Sep 2000 23:28:55 +0200 | From | Jens Axboe <> | Subject | Re: [patch] vmfixes-2.4.0-test9-B2 |
| |
On Mon, Sep 25 2000, Andrea Arcangeli wrote: > > The scsi layer currently "manually" does a list_add on the queue itself, > > which doesn't look too healthy. > > It's grabbing the io_request_lock so it looks healthy for now :)
It's safe alright, but if we want to do the generic_unplug_queue instead of just hitting the request_fn (which might do anything anyway), it would be nicer to expose this part of the block layer (i.e. have a general way of queueing a request to the request_queue). But I guess just
q->plug_device_fn(q, ...); list_add(...) generic_unplug_device(q);
would suffice in scsi_lib for now.
-- * Jens Axboe <axboe@suse.de> * SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |