lkml.org 
[lkml]   [2000]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] 2.4.0-test8: Alpha RTC clean-ups
On Mon, 25 Sep 2000, Jan-Benedict Glaw wrote:

> ./driver/char/rtc.c:rtc_init()
> #if defined(__alpha__) || defined(__mips__)
> [...]

That is wrong. I fixed this partially in the MIPS/Linux CVS tree a few
weeks ago. The __mips__ conditional is to be completely removed.

> MIPS does that as well _in the wrong way_ compared to rtc.c:
> ./arch/mips/dev/time.c:time_init()
> /*
> * The DECstation RTC is used as a TOY (Time Of Year).
> * The PROM will reset the year to either '70, '71 or '72.
> * This hack will only work until Dec 31 2001.
> */
> year += 1928;

We already handle this differently for the DECstation -- no need to check
the year from the RTC apart from handling leap years. The real year has
to be stored elsewhere. This is platform specific and other MIPS systems
are unaffected so the only check needed is whether we are on a DECstation
or not. As we don't have a unified MIPS kernel, this can be accomplished
at the compile time.

These changes will get into the official 2.4 kernel once a merge is
performed.

--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [from the cache]
©2003-2011 Jasper Spaans