Messages in this thread |  | | Date | Sun, 24 Sep 2000 22:38:14 +0100 | From | "Stephen C. Tweedie" <> | Subject | Re: __GFP_IO && shrink_[d|i]cache_memory()? |
| |
Hi,
On Sun, Sep 24, 2000 at 08:40:05PM +0200, Ingo Molnar wrote: > On Sun, 24 Sep 2000, Linus Torvalds wrote: > > > [...] I don't think shrinking the inode cache is actually illegal when > > GPF_IO isn't set. In fact, it's probably only the buffer cache itself > > that has to avoid recursion - the other stuff doesn't actually do any > > IO. > > i just found this out by example, i'm running the shrink_[i|d]cache stuff > even if __GFP_IO is not set, and no problems so far. (and much better > balancing behavior)
Careful --- I found out to my cost that there are hidden recursions here. ext3 was bitten once by the fact that shrink_icache does a quota drop, and that involves quota writeback if it was the last inode on that particular quota struct.
shrinking the icache _usually_ involves no IO, but the quota case is an exception which a lot of developers won't encounter during testing.
Cheers, Stephen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |